Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-162: Migrate test_relation #1134

Merged
merged 10 commits into from
Dec 14, 2023
Merged

PLAT-162: Migrate test_relation #1134

merged 10 commits into from
Dec 14, 2023

Conversation

ethho
Copy link
Contributor

@ethho ethho commented Dec 14, 2023

  • cp to tests
  • nose2pytest test_relation
  • WIP migrate test_relation
  • Move tests to top level
  • Fix typo in test
  • Format with black

ethho
ethho commented Dec 14, 2023
View reviewed changes
tests/test_relation.py
from . import schema


@pytest.fixture
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these fixtures are used in many different modules, we'll move them to conftest.py after migrating everything.

@ethho ethho requested a review from A-Baji December 14, 2023 15:52
@ethho ethho marked this pull request as ready for review December 14, 2023 15:52
@A-Baji A-Baji merged commit 74614b1 into datajoint:dev-tests Dec 14, 2023
9 checks passed
@ethho ethho mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-Baji A-Baji A-Baji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethho @A-Baji